shcizo
ec28d1e027
Docker Build / docker (push) Successful in 41s
## Summary
- Rebuilds the master's **Services** and **Agents** pages per the "Ledger" design: sidebar shell with live nav counts, machine filter and Live indicator; dark/light theme (follows the OS, toggle overrides); embedded Schibsted Grotesk and JetBrains Mono (fontsource 5.3.0, OFL).
- Services: Swarm grouped per cluster with its machines under it, offline banner ("Agent offline since HH:MM", browser-local), Simple Icons derived from the image ref (letter circle fallback), existing badges and mode switch restyled, client-side search, machine filter and Icon / Icon + text / Text toggle.
- Agents: Online / Offline / Never connected / Revoked, master version in the header with outdated agent versions marked, revoke via popover instead of `confirm()`, "Add agent" as a three-step panel that completes when the agent says hello (SSE `agents`).
- Store: migration `0005_agent_cluster.sql` persists each agent's `swarm_cluster_id` (needed to list a cluster's managers and its offline state after a master restart).
- SSE keepalive is now a named `ping` event so the Live indicator also shows the connection is alive. `revokeAgent` now publishes `agents`.
Closes #18
## Notes
- Workers never report a cluster id (Docker only sets `Swarm.Cluster` on managers), so their Swarm role shows "—". Fixing that needs a new hello field.
- Master binary grows by about 2.16 MB, almost all Simple Icons 16.35.0 path data (gzipped JSON, regenerated with `go generate ./internal/master/web/icons`). The agent binary does not import it.
- Jobs, Job and Service detail pages only get the new shell; their own artboards are out of scope, as are Update buttons, Update all, header stats and the drift badge.
- Unchanged: CSRF on every POST, `Cache-Control: no-store` on the token response, 401 + `HX-Redirect` without a session, no `template.HTML` on agent- or user-controlled values, no Node build step.
## Test plan
- [x] `go test ./...`, `go test -race ./internal/master/...`
- [x] `go test -tags integration ./internal/master/store/` against Postgres 17
- [x] `docker build`
- [x] Browser check on fake data: both themes, 1440 px and 390 px, add-agent flow through connect
- [ ] Services grouping and icons against real stacks and a real Swarm cluster
- [ ] "Agent offline since" after stopping an agent
- [ ] Theme toggle, search and machine filter across reloads and mode changes
- [ ] Add agent end to end with a real agent, Copy buttons
- [ ] Phone at 390 px
https://claude.ai/code/session_01GAZsp3P7Qto6JnhipxWUJQ
Reviewed-on: #29
47 lines
1.1 KiB
Go
47 lines
1.1 KiB
Go
package icons
|
|
|
|
import (
|
|
"regexp"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestForImage(t *testing.T) {
|
|
cases := []struct {
|
|
ref, want string
|
|
}{
|
|
{"gitea/gitea:1.27.3", "gitea"},
|
|
{"ghcr.io/goauthentik/server:2026.8.2", "authentik"},
|
|
{"postgres:17.10", "postgresql"},
|
|
{"grafana/loki:3.4.2", "grafana"},
|
|
{"docker.n8n.io/n8nio/n8n:1.112.4", "n8n"},
|
|
{"lscr.io/linuxserver/prowlarr:latest", ""},
|
|
{"localhost:5000/foo:v1", ""},
|
|
{"gitea.shcizo.se/shcizo/slusk:v0.8.1", ""},
|
|
}
|
|
for _, c := range cases {
|
|
t.Run(c.ref, func(t *testing.T) {
|
|
assert.Equal(t, c.want, ForImage(c.ref))
|
|
})
|
|
}
|
|
}
|
|
|
|
// safePath is a strict allowlist for what an embedded path may contain, since
|
|
// the paths are written into the page's HTML.
|
|
var safePath = regexp.MustCompile(`^[MmLlHhVvCcSsQqTtAaZz0-9.,\- e]+$`)
|
|
|
|
func TestEmbeddedSet(t *testing.T) {
|
|
assert.Greater(t, Count(), 3000)
|
|
for slug, p := range paths {
|
|
if !safePath.MatchString(p) {
|
|
t.Errorf("icon %q has unexpected characters in its path", slug)
|
|
}
|
|
}
|
|
p, ok := Path("gitea")
|
|
assert.True(t, ok)
|
|
assert.NotEmpty(t, p)
|
|
_, ok = Path("no-such-icon")
|
|
assert.False(t, ok)
|
|
}
|