fix(master): seed the tag digest from running services and hide registry error text (#9)

internal/master/poller/poller_test.go

@@ -30,7 +30,7 @@ type pollErrorCall struct {
 	msg string
 }
 
-type lastAutoCall struct {
+type lastTagCall struct {
 	id     int64
 	digest string
 }
@@ -39,7 +39,7 @@ type fakeStore struct {
 	mu         sync.Mutex
 	services   []model.Service
 	fresh      map[int64]model.Service // what GetService returns instead of the listed row
-	lastAuto   []lastAutoCall
+	lastTag    []lastTagCall
 	listErr    error
 	available  []availableCall
 	pollErrors []pollErrorCall
@@ -69,7 +69,7 @@ func (f *fakeStore) GetService(_ context.Context, id int64) (model.Service, erro
 func (f *fakeStore) SetLastTagDigest(_ context.Context, id int64, digest string) error {
 	f.mu.Lock()
 	defer f.mu.Unlock()
-	f.lastAuto = append(f.lastAuto, lastAutoCall{id, digest})
+	f.lastTag = append(f.lastTag, lastTagCall{id, digest})
 	for i := range f.services {
 		if f.services[i].ID == id {
 			f.services[i].LastTagDigest = digest
@@ -287,10 +287,10 @@ func TestNewDigest(t *testing.T) {
 				At: time.Date(2026, 10, 13, 12, 0, 0, 0, time.UTC)}, st.available[0].a)
 			if tt.wantStart {
 				assert.Equal(t, []startCall{{1, jobs.StartRequest{Trigger: model.TriggerPoll, Ref: ref}}}, j.starts)
-				assert.Equal(t, []lastAutoCall{{1, "sha256:new"}}, st.lastAuto)
+				assert.Equal(t, []lastTagCall{{1, "sha256:new"}}, st.lastTag)
 			} else {
 				assert.Empty(t, j.starts)
-				assert.Empty(t, st.lastAuto)
+				assert.Empty(t, st.lastTag)
 			}
 			assert.Equal(t, []events.Topic{events.Services}, pub.topics)
 		})
@@ -341,7 +341,7 @@ func TestStartErrorsDoNotAbortCycle(t *testing.T) {
 
 	assert.Len(t, st.available, 3)
 	assert.Len(t, j.starts, 3)
-	assert.Empty(t, st.lastAuto, "a job that was not created is retried next cycle")
+	assert.Empty(t, st.lastTag, "a job that was not created is retried next cycle")
 }
 
 func TestRollbackOfAutoServiceIsNotUndone(t *testing.T) {
@@ -366,7 +366,7 @@ func TestRollbackOfAutoServiceIsNotUndone(t *testing.T) {
 	p.Cycle(context.Background())
 
 	assert.Equal(t, []startCall{{1, jobs.StartRequest{Trigger: model.TriggerPoll, Ref: ref}}}, j.starts, "a new digest moves it again")
-	assert.Equal(t, []lastAutoCall{{1, "sha256:newer"}}, st.lastAuto)
+	assert.Equal(t, []lastTagCall{{1, "sha256:newer"}}, st.lastTag)
 }
 
 func TestActiveJobIsRetriedNextCycle(t *testing.T) {
@@ -380,13 +380,13 @@ func TestActiveJobIsRetriedNextCycle(t *testing.T) {
 
 	p.Cycle(context.Background())
 	require.Len(t, j.starts, 1)
-	assert.Empty(t, st.lastAuto)
+	assert.Empty(t, st.lastTag)
 
 	j.errFor = nil
 	p.Cycle(context.Background())
 
 	assert.Len(t, j.starts, 2)
-	assert.Equal(t, []lastAutoCall{{1, "sha256:new"}}, st.lastAuto)
+	assert.Equal(t, []lastTagCall{{1, "sha256:new"}}, st.lastTag)
 
 	p.Cycle(context.Background())
 	assert.Len(t, j.starts, 2, "started once the job exists")
@@ -423,7 +423,7 @@ func TestServiceSwitchedToManualDuringTheCycleIsNotStarted(t *testing.T) {
 
 	assert.Len(t, st.available, 1, "still suggested")
 	assert.Empty(t, j.starts)
-	assert.Empty(t, st.lastAuto)
+	assert.Empty(t, st.lastTag)
 }
 
 func TestErrorIsPerRef(t *testing.T) {
@@ -625,3 +625,27 @@ func TestRunReturnsDuringFirstDelay(t *testing.T) {
 }
 
 func ptr[T any](v T) *T { return &v }
+
+func TestSeedsTheTagDigestOfARunningService(t *testing.T) {
+	ref := repoA + ":main"
+	s := svc(1, ref+"@sha256:new")
+	s.UpdateMode = model.ModeAuto
+	s.ActualDigest = "sha256:new" // updated outside the updater: last_tag_digest is empty
+	st := &fakeStore{services: []model.Service{s}}
+	reg := &fakeRegistry{digests: map[string]string{ref: "sha256:new"}}
+	j := &fakeJobs{}
+	p, _ := newPoller(st, j, reg, Config{})
+
+	p.Cycle(context.Background())
+
+	assert.Equal(t, []lastTagCall{{1, "sha256:new"}}, st.lastTag)
+	assert.Empty(t, j.starts)
+
+	// Rolled back by hand to the older digest.
+	st.services[0].ActualRef, st.services[0].ActualDigest = ref+"@sha256:old", "sha256:old"
+	st.services[0].DesiredRef = ref + "@sha256:old"
+	p.Cycle(context.Background())
+
+	assert.Empty(t, j.starts, "the rollback stays")
+	assert.Len(t, st.lastTag, 1, "nothing more to seed")
+}