fix: zero excluded count in fallback, drop debug-icon orphan, align ejs guard (#21 )

feat: show excluded rounds count in player history accordion (#21 )
1.2.11
2026-05-25 09:44:46 +02:00 · 2026-05-25 09:34:42 +02:00 · 2026-05-25 06:04:26 +00:00 · 2026-05-25 08:04:14 +02:00 · 2026-05-25 08:02:05 +02:00 · 2026-05-25 07:54:46 +02:00
13 changed files with 62 additions and 213 deletions
@@ -1,12 +1,12 @@
 {
  "name": "pdga-ratings",
-  "version": "1.2.10",
+  "version": "1.2.11",
  "lockfileVersion": 3,
  "requires": true,
  "packages": {
    "": {
      "name": "pdga-ratings",
-      "version": "1.2.10",
+      "version": "1.2.11",
      "dependencies": {
        "ejs": "^4.0.1",
        "express": "^4.18.2",
@@ -1,6 +1,6 @@
 {
  "name": "pdga-ratings",
-  "version": "1.2.10",
+  "version": "1.2.11",
  "description": "PDGA rating scraper and display",
  "main": "server.js",
  "scripts": {
@@ -94,100 +94,6 @@
    box-shadow: var(--shadow-lg);
 }

-/* ── Tooltips ─────────────────────────────────── */
-
-.std-dev-tooltip {
-    position: absolute;
-    background: var(--navy-900);
-    color: var(--text-inverse);
-    padding: 6px 10px;
-    border-radius: var(--radius-sm);
-    font-size: 12px;
-    font-family: var(--font-mono);
-    pointer-events: none;
-    z-index: 10000;
-    display: none;
-    white-space: nowrap;
-    box-shadow: var(--shadow-lg);
-    font-weight: 400;
-}
-
-/* ── Debug Icon ───────────────────────────────── */
-
-.debug-icon:hover {
-    opacity: 1 !important;
-    color: var(--accent) !important;
-}
-
-/* ── Debug Modal ──────────────────────────────── */
-
-.debug-modal {
-    position: fixed;
-    top: 0;
-    left: 0;
-    width: 100%;
-    height: 100%;
-    background: rgba(15, 23, 42, 0.5);
-    backdrop-filter: blur(4px);
-    z-index: 10001;
-    display: none;
-    justify-content: center;
-    align-items: center;
-}
-
-.debug-content {
-    background: var(--surface-1);
-    border-radius: var(--radius-lg);
-    padding: 24px;
-    max-width: 640px;
-    width: 90%;
-    max-height: 80vh;
-    overflow-y: auto;
-    box-shadow: var(--shadow-overlay);
-    position: relative;
-}
-
-.debug-header {
-    font-weight: 700;
-    font-size: 16px;
-    margin-bottom: 16px;
-    color: var(--text-primary);
-    padding-bottom: 12px;
-    border-bottom: 1px solid var(--border);
-}
-
-.debug-log {
-    font-family: var(--font-mono);
-    background: var(--surface-2);
-    border: 1px solid var(--border);
-    border-radius: var(--radius-md);
-    padding: 16px;
-    font-size: 12px;
-    line-height: 1.6;
-    white-space: pre-line;
-    color: var(--text-primary);
-}
-
-.debug-close {
-    position: absolute;
-    top: 12px;
-    right: 16px;
-    font-size: 22px;
-    color: var(--text-muted);
-    cursor: pointer;
-    background: none;
-    border: none;
-    padding: 4px;
-    border-radius: var(--radius-sm);
-    transition: color var(--transition), background var(--transition);
-    line-height: 1;
-}
-
-.debug-close:hover {
-    color: var(--text-primary);
-    background: var(--surface-3);
-}
-
 /* ── Add Player Modal ─────────────────────────── */

 .modal {
@@ -1,4 +1,3 @@
-const cachedDebugInfo = {};
 let pendingPlayerData = null;
 let openPdgaNumber = null;

@@ -57,7 +56,6 @@ function setupAfterTableSwap() {
    document.body.addEventListener('htmx:afterSwap', function(event) {
        const target = event.detail.target;
        if (target.id === 'ratings-table') {
-            initRatingsTooltips();
            initChartsIn(target);
            return;
        }
@@ -67,31 +65,6 @@ function setupAfterTableSwap() {
    });
 }

-function initRatingsTooltips() {
-    document.querySelectorAll('.predicted-value').forEach(span => {
-        const pdgaNumber = span.dataset.pdga;
-        const stdDev = span.dataset.stddev;
-        const tooltip = document.getElementById(`tooltip-stddev-${pdgaNumber}`);
-
-        if (stdDev && tooltip) {
-            setupTooltip(span, tooltip, () => `Standard Deviation: \u00b1${stdDev}`);
-        }
-    });
-
-    document.querySelectorAll('.rating-value').forEach(span => {
-        const pdgaNumber = span.dataset.pdga;
-        const rating = parseInt(span.dataset.rating);
-        const stdDev = parseInt(span.dataset.stddev);
-        const tooltip = document.getElementById(`tooltip-rating-${pdgaNumber}`);
-
-        if (rating && stdDev && tooltip) {
-            const minRating = rating - stdDev;
-            const maxRating = rating + stdDev;
-            setupTooltip(span, tooltip, () => `Rating Range: ${minRating} - ${maxRating} (\u00b1${stdDev})`);
-        }
-    });
-}
-
 function togglePlayerHistory(pdgaNumber) {
    const historyRow = document.getElementById('history-' + pdgaNumber);
    const contentDiv = document.getElementById('history-content-' + pdgaNumber);
@@ -191,16 +164,6 @@ async function refreshPlayer(pdgaNumber) {
            if (ratingValue) {
                ratingValue.textContent = data.player.rating || 'N/A';
                ratingValue.dataset.rating = data.player.rating || '';
-
-                const stdDev = parseInt(ratingValue.dataset.stddev);
-                const rating = parseInt(data.player.rating);
-                const tooltip = document.getElementById(`tooltip-rating-${pdgaNumber}`);
-
-                if (rating && stdDev && tooltip) {
-                    const minRating = rating - stdDev;
-                    const maxRating = rating + stdDev;
-                    replaceWithTooltip(ratingValue, tooltip, () => `Rating Range: ${minRating} - ${maxRating} (\u00b1${stdDev})`);
-                }
            }

            const deltaMonthPill = ratingCell ? ratingCell.querySelector('.delta-pill') : null;
@@ -222,21 +185,12 @@ async function refreshRoundHistory(pdgaNumber) {
        }

        if (data.success) {
-            if (data.debugLog) {
-                cachedDebugInfo[pdgaNumber] = data.debugLog;
-            }
-
            const predictedCell = document.getElementById(`predicted-${pdgaNumber}`);
            if (predictedCell) {
                const predictedValue = predictedCell.querySelector('.predicted-value');
                if (predictedValue) {
                    predictedValue.textContent = data.predictedRating || 'N/A';
                    predictedValue.dataset.stddev = data.stdDev || '';
-
-                    const tooltip = document.getElementById(`tooltip-stddev-${pdgaNumber}`);
-                    if (data.stdDev && tooltip) {
-                        replaceWithTooltip(predictedValue, tooltip, () => `Standard Deviation: \u00b1${data.stdDev}`);
-                    }
                }
            }

@@ -245,16 +199,6 @@ async function refreshRoundHistory(pdgaNumber) {
            const ratingValue = ratingCell ? ratingCell.querySelector('.rating-value') : null;
            if (ratingValue && data.stdDev) {
                ratingValue.dataset.stddev = data.stdDev;
-
-                const rating = parseInt(ratingValue.dataset.rating);
-                const stdDev = parseInt(data.stdDev);
-                const ratingTooltip = document.getElementById(`tooltip-rating-${pdgaNumber}`);
-
-                if (rating && stdDev && ratingTooltip) {
-                    const minRating = rating - stdDev;
-                    const maxRating = rating + stdDev;
-                    replaceWithTooltip(ratingValue, ratingTooltip, () => `Rating Range: ${minRating} - ${maxRating} (\u00b1${stdDev})`);
-                }
            }
        }
    } catch (error) {
@@ -285,43 +229,6 @@ async function refreshRatingHistory(pdgaNumber) {
    }
 }

-async function showDebugInfo(pdgaNumber) {
-    const modal = document.getElementById('debug-modal');
-    const header = document.getElementById('debug-header');
-    const log = document.getElementById('debug-log');
-
-    const playerNameElement = document.querySelector(`#row-${pdgaNumber} .player-name a`);
-    const playerName = playerNameElement ? playerNameElement.textContent : `PDGA #${pdgaNumber}`;
-
-    header.textContent = `Prediction Calculation Details - ${playerName}`;
-    log.textContent = 'Loading calculation details...';
-    modal.style.display = 'flex';
-
-    try {
-        if (cachedDebugInfo[pdgaNumber]) {
-            log.textContent = cachedDebugInfo[pdgaNumber].join('\n');
-            return;
-        }
-
-        const response = await fetch(`/api/refresh-round-history/${pdgaNumber}`, { method: 'POST' });
-        const data = await response.json();
-
-        if (data.success && data.debugLog) {
-            cachedDebugInfo[pdgaNumber] = data.debugLog;
-            log.textContent = data.debugLog.join('\n');
-        } else {
-            log.textContent = 'No debug information available. Try refreshing the prediction first.';
-        }
-    } catch (error) {
-        console.error('Error fetching debug info:', error);
-        log.textContent = 'Error loading debug information. Please try again.';
-    }
-}
-
-function closeDebugModal(event) {
-    document.getElementById('debug-modal').style.display = 'none';
-}
-
 async function searchAndAddPlayer(event) {
    if (event) event.preventDefault();
    const input = document.getElementById('pdga-number-input');
@@ -763,7 +670,6 @@ async function refreshHistoryThenCalculate(pdgaNumber) {
            return;
        }

-        if (data.debugLog) cachedDebugInfo[pdgaNumber] = data.debugLog;
        const predictedCell = document.getElementById('predicted-' + pdgaNumber);
        if (predictedCell) {
            const predictedValue = predictedCell.querySelector('.predicted-value');
@@ -34,6 +34,7 @@ function initializeDatabase() {
          const hasLastRoundUpdate = columns.some(col => col.name === 'last_round_update');
          const hasPredictedRating = columns.some(col => col.name === 'predicted_rating');
          const hasStdDev = columns.some(col => col.name === 'std_dev');
+          const hasExcludedRoundsCount = columns.some(col => col.name === 'excluded_rounds_count');

          if (!hasLastRoundUpdate) {
            logger.info('Adding last_round_update column to players table...');
@@ -58,6 +59,14 @@ function initializeDatabase() {
              else logger.info('Successfully added std_dev column');
            });
          }
+
+          if (!hasExcludedRoundsCount) {
+            logger.info('Adding excluded_rounds_count column to players table...');
+            db.run(`ALTER TABLE players ADD COLUMN excluded_rounds_count INTEGER DEFAULT NULL`, (err) => {
+              if (err) logger.error('Error adding excluded_rounds_count column:', err.message);
+              else logger.info('Successfully added excluded_rounds_count column');
+            });
+          }
        });
      });

@@ -172,11 +172,11 @@ function saveRoundHistoryToDB(pdgaNumber, roundData, isIncremental = false) {
  });
 }

-function savePredictedRatingToDB(pdgaNumber, predictedRating, stdDev = null) {
+function savePredictedRatingToDB(pdgaNumber, predictedRating, stdDev = null, excludedRoundsCount = null) {
  return new Promise((resolve, reject) => {
    db.run(
-      'UPDATE players SET predicted_rating = ?, std_dev = ? WHERE pdga_number = ?',
-      [predictedRating, stdDev, pdgaNumber],
+      'UPDATE players SET predicted_rating = ?, std_dev = ?, excluded_rounds_count = ? WHERE pdga_number = ?',
+      [predictedRating, stdDev, excludedRoundsCount, pdgaNumber],
      function(err) {
        if (err) reject(err);
        else resolve();
@@ -400,7 +400,7 @@ router.post('/api/refresh-round-history/:pdgaNumber', async (req, res) => {

    const result = calculatePredictedRating(roundsForPrediction);

-    await savePredictedRatingToDB(pdgaNumber, result.rating, result.stdDev);
+    await savePredictedRatingToDB(pdgaNumber, result.rating, result.stdDev, result.excludedRoundsCount);

    const officialCount = allRounds.filter(r => r.source === 'official').length;
    const newCount = allRounds.filter(r => r.source === 'new').length;
@@ -409,7 +409,7 @@ router.post('/api/refresh-round-history/:pdgaNumber', async (req, res) => {
      success: true,
      predictedRating: result.rating,
      stdDev: result.stdDev,
-      debugLog: result.debugLog,
+      excludedRoundsCount: result.excludedRoundsCount,
      totalRounds: roundsForPrediction.length,
      officialRounds: officialCount,
      newRounds: newCount,
@@ -40,10 +40,12 @@ async function getPlayerDataFromDB(pdgaNumber, { includeMonthlyHistory = true }

      let predictedRating = cachedPlayer.predicted_rating;
      let stdDev = cachedPlayer.std_dev;
+      let excludedRoundsCount = cachedPlayer.excluded_rounds_count;
      if (!predictedRating || predictedRating === 0) {
        predictedRating = await getPredictedRatingFromDB(pdgaNumber);
        const updatedPlayer = await getPlayerFromDB(pdgaNumber);
        stdDev = updatedPlayer?.std_dev;
+        excludedRoundsCount = updatedPlayer?.excluded_rounds_count;
      }

      const rating = cachedPlayer.current_rating;
@@ -65,6 +67,7 @@ async function getPlayerDataFromDB(pdgaNumber, { includeMonthlyHistory = true }
        ratingChange,
        predictedRating: resolvedPredicted,
        stdDev: resolvedStdDev,
+        excludedRoundsCount: (excludedRoundsCount != null && excludedRoundsCount >= 0) ? excludedRoundsCount : null,
        lastMonthRating,
        // gap between next predicted update and current rating (null when either is missing)
        deltaPredicted: (resolvedPredicted != null && rating != null) ? resolvedPredicted - rating : null,
@@ -145,7 +148,7 @@ async function getPredictedRatingFromDB(pdgaNumber) {

      const result = calculatePredictedRating(roundRatings);

-      await savePredictedRatingToDB(pdgaNumber, result.rating, result.stdDev);
+      await savePredictedRatingToDB(pdgaNumber, result.rating, result.stdDev, result.excludedRoundsCount);

      return result.rating;
    }
@@ -229,6 +232,7 @@ async function getAllRatingsFromDB(progressCallback = null) {
          ratingChange: errorRatingChange,
          predictedRating: null,
          stdDev: null,
+          excludedRoundsCount: null,
          lastMonthRating: (errorRating != null && errorRatingChange != null) ? errorRating - errorRatingChange : null,
          deltaPredicted: null,
          monthlyHistory: [],
@@ -85,7 +85,7 @@ function calculatePredictedRating(roundRatings) {

  if (!roundRatings || roundRatings.length === 0) {
    debugLog.push('❌ No rounds provided for prediction');
-    return { rating: 0, debugLog };
+    return { rating: 0, debugLog, excludedRoundsCount: null };
  }

  debugLog.push(`📊 Starting with ${roundRatings.length} total rounds`);
@@ -100,7 +100,7 @@ function calculatePredictedRating(roundRatings) {

  if (allSortedRounds.length === 0) {
    debugLog.push('❌ No valid rounds after filtering for update date');
-    return { rating: 0, debugLog };
+    return { rating: 0, debugLog, excludedRoundsCount: null };
  }

  debugLog.push(`📊 After update date filter: ${allSortedRounds.length} rounds`);
@@ -127,7 +127,7 @@ function calculatePredictedRating(roundRatings) {

  if (eligibleRounds.length === 0) {
    debugLog.push('❌ No eligible rounds found');
-    return { rating: 0, debugLog };
+    return { rating: 0, debugLog, excludedRoundsCount: null };
  }

  debugLog.push(`📈 ELIGIBLE ROUNDS: ${eligibleRounds.length}`);
@@ -137,6 +137,7 @@ function calculatePredictedRating(roundRatings) {

  let workingRounds = [...eligibleRounds];
  let workingRatings = workingRounds.map(r => r.rating);
+  let excludedRoundsCount = 0;

  if (workingRatings.length >= 7) {
    debugLog.push('🔍 OUTLIER EXCLUSION (≥7 rounds available):');
@@ -160,6 +161,8 @@ function calculatePredictedRating(roundRatings) {
    const stdDevOutliers = workingRatings.filter(rating => rating < stdDevCutoff);
    const hundredPointOutliers = workingRatings.filter(rating => rating < hundredPointCutoff && rating >= stdDevCutoff);

+    excludedRoundsCount = stdDevOutliers.length + hundredPointOutliers.length;
+
    if (stdDevOutliers.length > 0) {
      debugLog.push(`   ❌ 2.5σ outliers removed: ${stdDevOutliers.length} rounds`);
      stdDevOutliers.forEach(rating => {
@@ -188,6 +191,7 @@ function calculatePredictedRating(roundRatings) {
      debugLog.push(`   ✅ Using ${filteredRatings.length} rounds after outlier removal`);
    } else {
      debugLog.push(`   ⚠️  Too few rounds after outlier removal (${filteredRatings.length}), keeping all rounds`);
+      excludedRoundsCount = 0;
    }
  } else {
    debugLog.push(`⏭️  OUTLIER EXCLUSION SKIPPED (only ${workingRatings.length} rounds, need ≥7)`);
@@ -228,7 +232,7 @@ function calculatePredictedRating(roundRatings) {
  debugLog.push(`   Final Rating: ${finalRating}`);
  debugLog.push('=== END PDGA CALCULATION ===');

-  return { rating: finalRating, stdDev: Math.round(stdDev), debugLog };
+  return { rating: finalRating, stdDev: Math.round(stdDev), debugLog, excludedRoundsCount };
 }

 module.exports = { parseDate, getNextPDGAUpdateDate, calculatePredictedRating, calculateStandardDeviation };
@@ -95,15 +95,6 @@
 `; %>

 <% var modals = `
-    <!-- Debug Modal -->
-    <div id="debug-modal" class="debug-modal" onclick="closeDebugModal(event)">
-        <div class="debug-content" onclick="event.stopPropagation()">
-            <button class="debug-close" onclick="closeDebugModal()">&times;</button>
-            <div class="debug-header" id="debug-header">Prediction Calculation Details</div>
-            <div class="debug-log" id="debug-log">Loading...</div>
-        </div>
-    </div>
-
    <!-- Add Player Confirmation Modal -->
    <div id="add-player-modal" class="modal" onclick="closeAddPlayerModal(event)">
        <div class="modal-content" onclick="event.stopPropagation()">
@@ -26,8 +26,23 @@ const chartPdgaNumber = hasPlayer ? player.pdgaNumber : pdgaNumber;
        <dt>Gap to predicted</dt>
        <dd><%- include('delta-pill', { value: player.deltaPredicted, extraClass: 'delta-predicted-pill' }) %></dd>
      </div>
+      <% if (player.stdDev != null && player.rating) { %>
+      <div>
+        <dt>Round spread</dt>
+        <dd>±<%= player.stdDev %></dd>
+      </div>
+      <div>
+        <dt>Rating range</dt>
+        <dd><%= player.rating - player.stdDev %>–<%= player.rating + player.stdDev %></dd>
+      </div>
+      <% } %>
+      <% if (player.excludedRoundsCount != null && player.rating) { %>
+      <div>
+        <dt>Excluded rounds</dt>
+        <dd><%= player.excludedRoundsCount %></dd>
+      </div>
+      <% } %>
    </dl>
-    <button class="link-btn" onclick="showDebugInfo(<%= player.pdgaNumber %>)" style="margin-top: 4px;">View calculation details →</button>
  </div>
  <% } %>

@@ -114,6 +114,22 @@ function renderSparkline(values, opts) {
                    <dt>Gap to predicted</dt>
                    <dd><span class="delta-pill <%= predCls %> delta-predicted-pill"><span class="delta-glyph"><%= predGlyph %></span><span class="delta-num"><%= predNum %></span></span></dd>
                </div>
+                <% if (player.stdDev != null && player.rating) { %>
+                <div>
+                    <dt>Round spread</dt>
+                    <dd>±<%= player.stdDev %></dd>
+                </div>
+                <div>
+                    <dt>Rating range</dt>
+                    <dd><%= player.rating - player.stdDev %>–<%= player.rating + player.stdDev %></dd>
+                </div>
+                <% } %>
+                <% if (player.excludedRoundsCount != null && player.rating) { %>
+                <div>
+                    <dt>Excluded rounds</dt>
+                    <dd><%= player.excludedRoundsCount %></dd>
+                </div>
+                <% } %>
            </dl>
        </div>
    </div>
@@ -67,7 +67,6 @@ function renderSparkline(values, opts) {
                    <% } else { %>
                    <span class="rating-pending">Click to load</span>
                    <% } %>
-                    <div class="std-dev-tooltip" id="tooltip-rating-<%= player.pdgaNumber %>"></div>
                </td>
                <td class="col-predicted" id="predicted-<%= player.pdgaNumber %>">
                    <% if (player.predictedRating) { %>
@@ -78,7 +77,6 @@ function renderSparkline(values, opts) {
                    <% } else { %>
                    <span class="rating-pending">—</span>
                    <% } %>
-                    <div class="std-dev-tooltip" id="tooltip-stddev-<%= player.pdgaNumber %>"></div>
                </td>
                <td class="col-actions cell-actions" onclick="event.stopPropagation()">
                    <button class="icon-btn refresh-icon" onclick="refreshPlayerData(<%= player.pdgaNumber %>)" title="Refresh rating + prediction" aria-label="Refresh rating and prediction">
Author	SHA1	Message	Date
Samuel Enocsson	f2e30c62aa	fix: zero excluded count in fallback, drop debug-icon orphan, align ejs guard (#21 )	2026-05-25 09:44:46 +02:00
Samuel Enocsson	0beeb98002	feat: show excluded rounds count in player history accordion (#21 )	2026-05-25 09:34:42 +02:00
Release Bot	f4c5e963d2	1.2.11 Release / release (push) Successful in 5s Details Build and deploy / build-and-push (push) Successful in 21s Details Build and deploy / deploy (push) Successful in 11s Details	2026-05-25 06:04:26 +00:00
shcizo	27d1bef8dd	Merge pull request 'fix: move std-dev info to accordion, remove broken tooltip (#19 )' (#20 ) from fix/std-dev-tooltip-positioning-and-discoverability-19 into main Release / release (push) Successful in 7s Details	2026-05-25 08:04:14 +02:00
Samuel Enocsson	088e283dcf	refactor: split round spread and rating range into separate accordion rows (#19 )	2026-05-25 08:02:05 +02:00
Samuel Enocsson	5791d8e34f	refactor: move std-dev info to accordion, remove tooltip (#19 ) - Add "Round spread" row (±stdDev, range lo–hi) to desktop accordion (player-history.ejs) and mobile card expanded section (ratings-cards.ejs) - Remove .std-dev-tooltip div and .std-dev-inline span from table partial - Remove stdDevTooltipText, updateStdDevInline, initRatingsTooltips helpers and all call sites from players.js - Remove .std-dev-tooltip and .std-dev-inline CSS rules; drop cursor:help from .rating-value	2026-05-25 07:54:46 +02:00
Samuel Enocsson	1ff768e2fa	fix: address std-dev inline span refresh + style fixes (#19 ) - A: create inline span when missing in refreshRoundHistory (was silently dropped) - B: updateStdDevInline also called from refreshHistoryThenCalculate - C: extract stdDevTooltipText + updateStdDevInline helpers; replace 3 call sites - D: remove margin-left: 4px and bump font-size to 12px on .std-dev-inline - E: guard against stdDev === 0 in EJS (truthy → != null)	2026-05-23 06:45:39 +02:00
Samuel Enocsson	c3fb850de3	fix: reposition std-dev tooltip and surface ±-spread inline (#19 )	2026-05-23 06:40:08 +02:00